Re: SUNRPC: Checking a kmemdup() call in xdr_netobj_dup()

From: J. Bruce Fields
Date: Mon Oct 14 2019 - 18:34:13 EST

On Sat, Oct 12, 2019 at 08:20:04PM +0200, Markus Elfring wrote:
> I tried another script for the semantic patch language out.
> This source code analysis approach points out that the implementation
> of the function âxdr_netobj_dupâ contains still an unchecked call
> of the function âkmemdupâ.
> How do you think about to improve it?

On a quick check--I see five xdr_netobj_dup callers, and all of them
check whether dst->data is NULL.

Sounds like a false positive for your tool?