Re: [PATCH v4] arm64: use generic free_initrd_mem()
From: Will Deacon
Date: Mon Oct 14 2019 - 20:47:06 EST
On Sat, Sep 28, 2019 at 11:02:26AM +0300, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@xxxxxxxxxxxxx>
> arm64 calls memblock_free() for the initrd area in its implementation of
> free_initrd_mem(), but this call has no actual effect that late in the boot
> process. By the time initrd is freed, all the reserved memory is managed by
> the page allocator and the memblock.reserved is unused, so the only purpose
> of the memblock_free() call is to keep track of initrd memory for debugging
> and accounting.
> Without the memblock_free() call the only difference between arm64 and the
> generic versions of free_initrd_mem() is the memory poisoning.
> Move memblock_free() call to the generic code, enable it there
> for the architectures that define ARCH_KEEP_MEMBLOCK and use the generic
> implementation of free_initrd_mem() on arm64.
> Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxx>
> * memblock_free() aligned area around the initrd
Looks straightforward to me:
Acked-by: Will Deacon <will@xxxxxxxxxx>