Re: [PATCH] sh: use dma_to_phys() instead of dev->dma_pfn_offset

From: Nicolas Saenz Julienne
Date: Tue Oct 15 2019 - 04:05:57 EST

On Tue, 2019-10-15 at 00:43 -0700, Christoph Hellwig wrote:
> On Fri, Oct 11, 2019 at 06:51:29PM +0200, Nicolas Saenz Julienne wrote:
> > It's more explicit and lets dma-direct handle the specifics of how to
> > translate addresses.
> >
> > On top of that get rid of warnings as, since the introduction of commit
> > 6fa1d28e38c ("sh: use generic dma_noncoherent_ops"), it's impossible for
> > the dev to be NULL.
> This looks ok, but the real answer is to switch sh to the generic
> dma remapping code. I've been trying to get this included for about
> a year now, but never managed to get a reply from the sh maintainers.

I see, well I guess this one will get ignored too :)

> Here is the last one:

I'd be happy with your series too.

In case you're wondering why I want this: I'm interested in supporting multiple
dma-ranges in DT. So I was looking at the amount of work needed to centralize
usage of dev->dma_pfn_offset. This one patch seemed trivial enough to send
right away.


Attachment: signature.asc
Description: This is a digitally signed message part