Re: linux-next: build warning after merge of the pm tree
From: Rafael J. Wysocki
Date: Tue Oct 15 2019 - 05:41:58 EST
On Tuesday, October 15, 2019 10:23:33 AM CEST Andy Shevchenko wrote:
> On Tue, Oct 15, 2019 at 10:08:55AM +1100, Stephen Rothwell wrote:
> > Hi all,
> > After merging the pm tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> > In file included from include/linux/irqchip.h:14,
> > from arch/arm/kernel/irq.c:26:
> > include/linux/acpi.h:682:31: warning: 'struct acpi_device' declared inside parameter list will not be visible outside of this definition or declaration
> > 682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2, const char *uid2)
> > | ^~~~~~~~~~~
> > and many more.
> > Introduced by commit
> > d1748b57dc88 ("ACPI / utils: Introduce acpi_dev_hid_uid_match() helper")
> > CONFIG_ACPI is not set for this build.
> I'm puzzled. Why it builds before?
> Another function has struct acpi_device *adev in its prototype and it was
> before above mentioned commit.
The very next acpi_dev_get_first_match_dev() returns a pointer to
struct acpi_device too and it is not modified by the commit in question.
There may be a bug in there, but commit d1748b57dc88 doesn't look like the
source of it.