Re: [PATCH v2] arm64: entry.S: Do not preempt from IRQ before all cpufeatures are enabled

From: Will Deacon
Date: Tue Oct 15 2019 - 16:08:03 EST


Hi James,

Patch looks good apart from one thing...

On Tue, Oct 15, 2019 at 06:25:44PM +0100, James Morse wrote:
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index 2c2e56bd8913..67a1d86981a9 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -223,6 +223,7 @@ extern long schedule_timeout_uninterruptible(long timeout);
> extern long schedule_timeout_idle(long timeout);
> asmlinkage void schedule(void);
> extern void schedule_preempt_disabled(void);
> +asmlinkage void preempt_schedule_irq(void);

I don't understand the need for this hunk, since we're only calling the
function from C now. Please could you explain?

Will