Re: [PATCH 00/15] thermal: qcom: tsens: Add interrupt support

From: Amit Kucheria
Date: Wed Oct 16 2019 - 04:35:34 EST


On Wed, Oct 16, 2019 at 1:29 PM Daniel Lezcano
<daniel.lezcano@xxxxxxxxxx> wrote:
>
> On 16/10/2019 09:33, Amit Kucheria wrote:
> > Hi Thermal and MSM maintainers,
> >
> > I believe this series is now ready to be merged. The DT bindings and driver
> > changes should go through the thermal tree and the changes to the DT files
> > themselves should go through the MSM tree. There is no hard ordering
> > dependency because we're adding a new property to the driver. It would help
> > to soak in linux-next for a few weeks to catch anything on kernelci.org.
>
> So the ones going to thermal are:
>
> 1-7, 14, 15 right ?

1-4, 7, 14, 15 => thermal tree
5, 6, 8-13 => msm tree

I guess I could have ordered it better for merging :-/

> > Changes since v4:
> > - Change to of-thermal core[1] to force interrupts w/o changing polling-delay DT
> > parameter
> > - Corresponding changes to DT files to remove the hunks setting the values
> > to 0
> > - Collected reviews and acks
> >
> > Changes since v3:
> > - Fix up the YAML definitions based on Rob's review
> >
> > Changes since v2:
> > - Addressed Stephen's review comment
> > - Moved the dt-bindings to yaml (This throws up some new warnings in various QCOM
> > devicetrees. I'll send out a separate series to fix them up)
> > - Collected reviews and acks
> > - Added the dt-bindings to MAINTAINERS
> >
> > Changes since v1:
> > - Collected reviews and acks
> > - Addressed Stephen's review comments (hopefully I got them all).
> > - Completely removed critical interrupt infrastructure from this series.
> > Will post that separately.
> > - Fixed a bug in sign-extension of temperature.
> > - Fixed DT bindings to use the name of the interrupt e.g. "uplow" and use
> > platform_get_irq_byname().
> >
> > Add interrupt support to TSENS. The first 6 patches are general fixes and
> > cleanups to the driver before interrupt support is introduced.
> >
> > [1] https://lore.kernel.org/linux-arm-msm/1b53ef537203e629328285b4597a09e4a586d688.1571181041.git.amit.kucheria@xxxxxxxxxx/
> >
> > Amit Kucheria (15):
> > drivers: thermal: tsens: Get rid of id field in tsens_sensor
> > drivers: thermal: tsens: Simplify code flow in tsens_probe
> > drivers: thermal: tsens: Add __func__ identifier to debug statements
> > drivers: thermal: tsens: Add debugfs support
> > arm: dts: msm8974: thermal: Add thermal zones for each sensor
> > arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors
> > dt-bindings: thermal: tsens: Convert over to a yaml schema
> > arm64: dts: sdm845: thermal: Add interrupt support
> > arm64: dts: msm8996: thermal: Add interrupt support
> > arm64: dts: msm8998: thermal: Add interrupt support
> > arm64: dts: qcs404: thermal: Add interrupt support
> > arm: dts: msm8974: thermal: Add interrupt support
> > arm64: dts: msm8916: thermal: Add interrupt support
> > drivers: thermal: tsens: Create function to return sign-extended
> > temperature
> > drivers: thermal: tsens: Add interrupt support
> >
> > .../bindings/thermal/qcom-tsens.txt | 55 --
> > .../bindings/thermal/qcom-tsens.yaml | 168 ++++++
> > MAINTAINERS | 1 +
> > arch/arm/boot/dts/qcom-msm8974.dtsi | 92 +++
> > arch/arm64/boot/dts/qcom/msm8916.dtsi | 6 +-
> > arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 +
> > arch/arm64/boot/dts/qcom/msm8998.dtsi | 6 +-
> > arch/arm64/boot/dts/qcom/qcs404.dtsi | 2 +
> > arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 +
> > drivers/thermal/qcom/tsens-8960.c | 4 +-
> > drivers/thermal/qcom/tsens-common.c | 529 ++++++++++++++++--
> > drivers/thermal/qcom/tsens-v0_1.c | 11 +
> > drivers/thermal/qcom/tsens-v1.c | 29 +
> > drivers/thermal/qcom/tsens-v2.c | 13 +
> > drivers/thermal/qcom/tsens.c | 58 +-
> > drivers/thermal/qcom/tsens.h | 286 ++++++++--
> > 16 files changed, 1102 insertions(+), 166 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/thermal/qcom-tsens.txt
> > create mode 100644 Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> >
>
>
> --
> <http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>