Re: [PATCH -next] drm/amd/display: Make dc_link_detect_helper static

From: Alex Deucher
Date: Wed Oct 16 2019 - 12:19:35 EST


On Wed, Oct 16, 2019 at 8:29 AM YueHaibing <yuehaibing@xxxxxxxxxx> wrote:
>
> Fix sparse warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:746:6:
> warning: symbol 'dc_link_detect_helper' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Applied. thanks!

Alex

> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> index fb18681..9350536 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
> @@ -743,7 +743,8 @@ static bool wait_for_alt_mode(struct dc_link *link)
> * This does not create remote sinks but will trigger DM
> * to start MST detection if a branch is detected.
> */
> -bool dc_link_detect_helper(struct dc_link *link, enum dc_detect_reason reason)
> +static bool dc_link_detect_helper(struct dc_link *link,
> + enum dc_detect_reason reason)
> {
> struct dc_sink_init_data sink_init_data = { 0 };
> struct display_sink_capability sink_caps = { 0 };
> --
> 2.7.4
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx