Re: [PATCH v2 1/5] proc/meminfo: fix output alignment

From: Yang Shi
Date: Thu Oct 17 2019 - 13:37:57 EST


On Thu, Oct 17, 2019 at 9:42 AM Song Liu <songliubraving@xxxxxx> wrote:
>
> From: "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>
>
> Add extra space for FileHugePages and FilePmdMapped, so the output is
> aligned with other rows.
>
> Fixes: 60fbf0ab5da1 ("mm,thp: stats for file backed THP")
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> Tested-by: Song Liu <songliubraving@xxxxxx>
> Signed-off-by: Song Liu <songliubraving@xxxxxx>

Acked-by: Yang Shi <yang.shi@xxxxxxxxxxxxxxxxx>

> ---
> fs/proc/meminfo.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c
> index ac9247371871..8c1f1bb1a5ce 100644
> --- a/fs/proc/meminfo.c
> +++ b/fs/proc/meminfo.c
> @@ -132,9 +132,9 @@ static int meminfo_proc_show(struct seq_file *m, void *v)
> global_node_page_state(NR_SHMEM_THPS) * HPAGE_PMD_NR);
> show_val_kb(m, "ShmemPmdMapped: ",
> global_node_page_state(NR_SHMEM_PMDMAPPED) * HPAGE_PMD_NR);
> - show_val_kb(m, "FileHugePages: ",
> + show_val_kb(m, "FileHugePages: ",
> global_node_page_state(NR_FILE_THPS) * HPAGE_PMD_NR);
> - show_val_kb(m, "FilePmdMapped: ",
> + show_val_kb(m, "FilePmdMapped: ",
> global_node_page_state(NR_FILE_PMDMAPPED) * HPAGE_PMD_NR);
> #endif
>
> --
> 2.17.1
>
>