Re: [PATCH] net/lib80211: scrubbing the buffer for key

From: Johannes Berg
Date: Fri Oct 18 2019 - 04:43:27 EST


On Thu, 2019-10-17 at 23:53 -0500, Kangjie Lu wrote:
> The "key" is not scrubbed. As what peer modules do, the fixes zeros
> out the key buffer.

Why do you think this is useful/necessary? Please always describe that
in the commit log.

FWIW, I'm convinced that it's not at necessary at all, looking at how
this is allocated ...

johannes