Re: [PATCH 1/2] x86, mce, therm_throt: Optimize logging of thermal throttle messages

From: Borislav Petkov
Date: Fri Oct 18 2019 - 15:40:28 EST


On Fri, Oct 18, 2019 at 08:55:17AM -0700, Srinivas Pandruvada wrote:
> I assume that someone is having performance issues or occasion reboots,
> look at the logs. Is it a fair assumption?

Yes, that is a valid use case IMO.

> But if a system is running at up to 87.5% of duty cycle on top of
> lowest possible frequency of around 800MHz, someone will notice.

Yes, but that doesn't justify for those printk statements to be
KERN_CRIT. They're just fine as warnings.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette