Re: [PATCH net-next 0/8] net: hns3: add some cleanups & optimizations

From: Jakub Kicinski
Date: Sun Oct 20 2019 - 13:38:18 EST


On Sat, 19 Oct 2019 16:03:48 +0800, Huazhong Tan wrote:
> This patchset includes some cleanups and optimizations for the HNS3
> ethernet driver.
>
> [patch 1/8] removes unused and unnecessary structures.
>
> [patch 2/8] uses a ETH_ALEN u8 array to replace two mac_addr_*
> field in struct hclge_mac_mgr_tbl_entry_cmd.
>
> [patch 3/8] optimizes the barrier used in the IO path.
>
> [patch 4/8] introduces macro ring_to_netdev() to get netdevive
> from struct hns3_enet_ring variable.
>
> [patch 5/8] makes struct hns3_enet_ring to be cacheline aligned
>
> [patch 6/8] adds a minor cleanup for hns3_handle_rx_bd().
>
> [patch 7/8] removes linear data allocating for fraglist SKB.
>
> [patch 8/8] clears hardware error when resetting.
>
> ---
> note:
> In previous patchset, there are some bugfixes which needs below
> new feature, which is only in 'net-next' but not in 'net' now:
> net: hns3: support tx-scatter-gather-fraglist feature
> net: hns3: add support for spoof check setting
>
> So, these bugfixes will be upstreamed when the patch needed is
> on 'net' tree.

Thanks! Looks good to me now.