Re: [PATCH] mmc: fix mmc dma operation

From: Jianxin Pan
Date: Mon Oct 21 2019 - 04:23:53 EST


Hi Neil,

Thanks for the review, I will update the subject and commit message in the next version.

On 2019/10/21 15:57, Neil Armstrong wrote:
> Hi,
>
> Thanks for the fix.
>
> First, you should add "mmc: meson-gx:" in the subject.
>
> On 21/10/2019 07:59, Jianxin Pan wrote:
>> From: Nan Li <nan.li@xxxxxxxxxxx>
>>
>> In MMC dma transfer, the region requested by dma_map_sg() may be released
>> by dma_unmap_sg() before the transfer is completed.
>>
>> Put the unmap operation in front of mmc_request_done() to avoid this.
>
>
> You should add a "Fixes:" tag so it can be backported on stable kernels.
>
>>
>> Signed-off-by: Nan Li <nan.li@xxxxxxxxxxx>
>> Signed-off-by: Jianxin Pan <jianxin.pan@xxxxxxxxxxx>
>> ---
>> drivers/mmc/host/meson-gx-mmc.c | 15 ++++++++-------
>> 1 file changed, 8 insertions(+), 7 deletions(-)
>>
[...]
>> }
>>
>> static void meson_mmc_read_resp(struct mmc_host *mmc, struct mmc_command *cmd)
>>
> Neil
>
> .
>