Re: [PATCH v5 0/2] perf: add support for logging debug messages to file

[Namhyung Kim]

Hello,

On Fri, Oct 18, 2019 at 9:28 AM Changbin Du <changbin.du@xxxxxxxxx> wrote:
>
> When in TUI mode, it is impossible to show all the debug messages to
> console. This make it hard to debug perf issues using debug messages.
> This patch adds support for logging debug messages to file to resolve
> this problem.

I thought I implemented a debug message view in TUI mode by saving
all the messages in a linked list.  But it seems not sent to the list and I
cannot find it now. :(

Anyway I understand your concerns and the changes look ok to me, so

Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks
Namhyung


>
> v5:
>   o doc default log path.
> v4:
>   o fix another segfault.
> v3:
>   o fix a segfault issue.
> v2:
>   o specific all debug options one time.
>
> Changbin Du (2):
>   perf: support multiple debug options separated by ','
>   perf: add support for logging debug messages to file
>
>  tools/perf/Documentation/perf.txt |  16 ++--
>  tools/perf/util/debug.c           | 124 ++++++++++++++++++++----------
>  2 files changed, 92 insertions(+), 48 deletions(-)
>
> --
> 2.20.1
>