Re: [RFC PATCH v2 11/16] mm,hwpoison: Rework soft offline for in-use pages

From: Oscar Salvador
Date: Tue Oct 22 2019 - 05:41:00 EST


On Tue, Oct 22, 2019 at 10:30:02AM +0200, Michal Hocko wrote:
> But we have destructors for compound pages. Can we do the heavy lifting
> there?

Yes, we could.
Actually, I tried that approach, but I thought it was simpler this way.
Since there is no hurry in this, I will try to take that up again and
see how it looks.

> > > If the page is free then it shouldn't pin the memcg or any other state.
> >
> > Well, it is not really free, as it is not usable, is it?
>
> Sorry I meant to say the page is free from the memcg POV - aka no task
> from the memcg is holding a reference to it. The page is not usable for
> anybody, that is true but no particular memcg should pay a price for
> that. This would mean that random memcgs would end up pinned for ever
> without a good reason.

Sure, I will re-work that.

--
Oscar Salvador
SUSE L3