Re: [PATCH v7 00/12] implement KASLR for powerpc/fsl_booke/32

From: Scott Wood
Date: Tue Oct 22 2019 - 19:29:43 EST


On Mon, 2019-10-21 at 11:34 +0800, Jason Yan wrote:
>
> On 2019/10/10 2:46, Scott Wood wrote:
> > On Wed, 2019-10-09 at 16:41 +0800, Jason Yan wrote:
> > > Hi Scott,
> > >
> > > On 2019/10/9 15:13, Scott Wood wrote:
> > > > On Wed, 2019-10-09 at 14:10 +0800, Jason Yan wrote:
> > > > > Hi Scott,
> > > > >
> > > > > Would you please take sometime to test this?
> > > > >
> > > > > Thank you so much.
> > > > >
> > > > > On 2019/9/24 13:52, Jason Yan wrote:
> > > > > > Hi Scott,
> > > > > >
> > > > > > Can you test v7 to see if it works to load a kernel at a non-zero
> > > > > > address?
> > > > > >
> > > > > > Thanks,
> > > >
> > > > Sorry for the delay. Here's the output:
> > > >
> > >
> > > Thanks for the test.
> > >
> > > > ## Booting kernel from Legacy Image at 10000000 ...
> > > > Image Name: Linux-5.4.0-rc2-00050-g8ac2cf5b4
> > > > Image Type: PowerPC Linux Kernel Image (gzip compressed)
> > > > Data Size: 7521134 Bytes = 7.2 MiB
> > > > Load Address: 04000000
> > > > Entry Point: 04000000
> > > > Verifying Checksum ... OK
> > > > ## Flattened Device Tree blob at 1fc00000
> > > > Booting using the fdt blob at 0x1fc00000
> > > > Uncompressing Kernel Image ... OK
> > > > Loading Device Tree to 07fe0000, end 07fff65c ... OK
> > > > KASLR: No safe seed for randomizing the kernel base.
> > > > OF: reserved mem: initialized node qman-fqd, compatible id fsl,qman-
> > > > fqd
> > > > OF: reserved mem: initialized node qman-pfdr, compatible id fsl,qman-
> > > > pfdr
> > > > OF: reserved mem: initialized node bman-fbpr, compatible id fsl,bman-
> > > > fbpr
> > > > Memory CAM mapping: 64/64/64 Mb, residual: 12032Mb
> > >
> > > When boot from 04000000, the max CAM value is 64M. And
> > > you have a board with 12G memory, CONFIG_LOWMEM_CAM_NUM=3 means only
> > > 192M memory is mapped and when kernel is randomized at the middle of
> > > this 192M memory, we will not have enough continuous memory for node
> > > map.
> > >
> > > Can you set CONFIG_LOWMEM_CAM_NUM=8 and see if it works?
> >
> > OK, that worked.
> >
>
> Hi Scott, any more cases should be tested or any more comments?
> What else need to be done before this feature can be merged?

I've just applied it and sent a pull request.

-Scott