Re: [PATCH] riscv: fix fs/proc/kcore.c compilation with sparsemem enabled

From: Paul Walmsley
Date: Tue Oct 22 2019 - 20:06:36 EST


On Tue, 22 Oct 2019, David Abdurachmanov wrote:

> Failed to compile Fedora/RISCV kernel (5.4-rc3+) with sparsemem enabled:
>
> fs/proc/kcore.c: In function 'read_kcore':
> fs/proc/kcore.c:510:8: error: implicit declaration of function 'kern_addr_valid'; did you mean 'virt_addr_valid'? [-Werror=implicit-function-declaration]
> 510 | if (kern_addr_valid(start)) {
> | ^~~~~~~~~~~~~~~
> | virt_addr_valid
>
> Looking at other architectures I don't see kern_addr_valid being guarded by
> CONFIG_FLATMEM.
>
> Fixes: d95f1a542c3d ("RISC-V: Implement sparsemem")
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@xxxxxxxxxx>
> Tested-by: David Abdurachmanov <david.abdurachmanov@xxxxxxxxxx>

Thanks, queued for v5.4-rc with Logan's Reviewed-by:.


- Paul