Re: [PATCH] ASoC: rsnd: dma: set bus width to data width for monaural data

From: Kuninori Morimoto
Date: Tue Oct 22 2019 - 20:56:12 EST



Hi

> According to R-Car3 HW manual 40.3.3 (Data Format on Audio Local Bus),
> in case of monaural data writing or reading through Audio-DMAC,
> it's always in Left Justified format, so both src and dst
> DMA Bus width should be equal to physical data width.
>
> Therefore set src and dst's DMA bus width to:
> - [monaural case] data width
> - [non-monaural case] 32bits (as prior applying the patch)
>
> Cc: Andrew Gabbasov <andrew_gabbasov@xxxxxxxxxx>
> Cc: Timo Wischer <twischer@xxxxxxxxxxxxxx>
> Signed-off-by: Jiada Wang <jiada_wang@xxxxxxxxxx>
> Signed-off-by: Eugeniu Rosca <erosca@xxxxxxxxxxxxxx>
> ---

I don't know how Monaural works, but I know you are using it.
Thus don't say Acked-by and/or Reviewed-by,
but I have no objection about this patch.

Thank you for your help !!
Best regards
---
Kuninori Morimoto