RE: [PATCH] namespace: fix namespace.pl script to support relative paths

From: Keller, Jacob E
Date: Wed Oct 23 2019 - 17:34:09 EST


> -----Original Message-----
> From: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> Sent: Tuesday, October 22, 2019 10:22 PM
> To: Keller, Jacob E <jacob.e.keller@xxxxxxxxx>; Randy Dunlap
> <rdunlap@xxxxxxxxxxxxx>
> Cc: intel-wired-lan@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-kbuild
> <linux-kbuild@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH] namespace: fix namespace.pl script to support relative
> paths
>
> This scripts has been 5-year broken,
> and I did not see any complaint except from you.
> So, I wonder how many people are using this.
>
> Nor, do I understand how to use it.
>
> Could you teach me a bit more about this script?
>
>
>
> Something might be missing in my mind, but
> I do not know how to use this script in a useful way.
>
>
>
> It provides three checks.
>
> [1] list_multiply_defined()
>
> This warns multiple definition of functions.
>
> The compiler would fail if it saw any multiple definition,
> so the reports from this check are all false-positive.
>
>
> [2] resolve_external_references()
>
> This warns unresolved symbols.
>
> The compiler would fail if it saw any unresolved symbol,
> so the reports from this check are all false-positive, too.
>
>

The compiler won't necessarily fail when building modules, because the symbol might be in another loadable module.

>
>
> [3] list_extra_externals
>
> This warns symbols with no reference.
>
> This potentially contains lots of false-positives.
> For example, the core framework provides APIs, but if all drivers
> are disabled, there is no user of those APIs.
>

We use this to help verify that driver modules do not expose symbols.

Thanks,
Jake