Re: [PATCH v6 02/10] iommu/vt-d: Add custom allocator for IOASID

From: Jacob Pan
Date: Wed Oct 23 2019 - 18:59:45 EST


On Tue, 22 Oct 2019 21:04:00 -0700
Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx> wrote:

> > > + if (cap_caching_mode(iommu->cap) &&
> > > sm_supported(iommu)) {
> >
> > do you need to check against cap_caching_mode() or ecap_vcmd?
> >
> I guess ecap_vcmd() will suffice. Kind of redundant.
Actually, we can check vcmd and vcmd_pasid here, then we dont need to
check it on every alloc/free calls.

Thanks,

Jacob