Re: [PATCH 3/7] nvmet: Introduce common execute function for get_log_page and identify

From: Christoph Hellwig
Date: Wed Oct 23 2019 - 21:17:49 EST


On Wed, Oct 23, 2019 at 10:35:41AM -0600, Logan Gunthorpe wrote:
> Instead of picking the sub-command handler to execute in a nested
> switch statement introduce a landing functions that calls out
> to the appropriate sub-command handler.
>
> This will allow us to have a common place in the handler to check
> the transfer length in a future patch.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> [logang@xxxxxxxxxxxx: separated out of a larger draft patch from hch]
> Signed-off-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>

First signoff needs to be the From line picked up by git. I don't really
care if you keep my attribution or not, but if you do it needs From
line for me as the first theing in the mail body, and if not it
should drop by signoff and just say based on a patch from me.

Otherwise the series looks fine.