Re: [PATCH v4 15/16] module: Move where we mark modules RO,X

From: Peter Zijlstra
Date: Thu Oct 24 2019 - 06:18:31 EST


On Thu, Oct 24, 2019 at 12:16:09PM +0200, Peter Zijlstra wrote:
> +struct trace_event_fields {
> + const char *type;
> + union {
> + struct {
> + const char *name;
> + const int size;
> + const int align;
> + const int is_signed;
> + const int filter_type;

FWIW, I suspect we can do:

unsigned char size;
unsigned char align;
unsigned char is_signed;
unsigned char filter_type;

And save us some 8 bytes per entry (12 on 32bit).

> + };
> + int (*define_fields)(struct trace_event_call *);
> + };
> +};