Re: [PATCH 0/7] towards QE support on ARM

From: Li Yang
Date: Thu Oct 24 2019 - 16:03:16 EST


On Tue, Oct 22, 2019 at 9:54 PM Qiang Zhao <qiang.zhao@xxxxxxx> wrote:
>
> On 22/10/2019 18:18, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx> wrote:
> > -----Original Message-----
> > From: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
> > Sent: 2019å10æ22æ 18:18
> > To: Qiang Zhao <qiang.zhao@xxxxxxx>; Leo Li <leoyang.li@xxxxxxx>
> > Cc: Timur Tabi <timur@xxxxxxxxxx>; Greg Kroah-Hartman
> > <gregkh@xxxxxxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> > linux-serial@xxxxxxxxxxxxxxx; Jiri Slaby <jslaby@xxxxxxxx>;
> > linuxppc-dev@xxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Subject: Re: [PATCH 0/7] towards QE support on ARM
> >
> > On 22/10/2019 04.24, Qiang Zhao wrote:
> > > On Mon, Oct 22, 2019 at 6:11 AM Leo Li wrote
> >
> > >> Right. I'm really interested in getting this applied to my tree and
> > >> make it upstream. Zhao Qiang, can you help to review Rasmus's
> > >> patches and comment?
> > >
> > > As you know, I maintained a similar patchset removing PPC, and someone
> > told me qe_ic should moved into drivers/irqchip/.
> > > I also thought qe_ic is a interrupt control driver, should be moved into dir
> > irqchip.
> >
> > Yes, and I also plan to do that at some point. However, that's orthogonal to
> > making the driver build on ARM, so I don't want to mix the two. Making it
> > usable on ARM is my/our priority currently.
> >
> > I'd appreciate your input on my patches.
>
> Yes, we can put this patchset in first place, ensure it can build and work on ARM, then push another patchset to move qe_ic.

Right. I would only accept a patch series that can really build and
work on ARM. At least the current out-of-tree patches can make it
work on ARM. If we accept partial changes, there is no way to make it
work on the latest kernel on ARM then.

Regards,
Leo