Re: [PATCH] x86/hyper-v: micro-optimize send_ipi_one case

From: Thomas Gleixner
Date: Thu Oct 24 2019 - 18:38:12 EST


On Thu, 24 Oct 2019, Roman Kagan wrote:
> > +
> > + if (cpu >= 64)
> > + goto do_ex_hypercall;
> > +
> > + ret = hv_do_fast_hypercall16(HVCALL_SEND_IPI, vector,
> > + BIT_ULL(hv_cpu_number_to_vp_number(cpu)));
> > + return ((ret == 0) ? true : false);
>
> D'oh. Isn't "return ret == 0;" or just "return ret;" good enough?

'return ret == 0' != 'return ret'

!ret perhaps :)

Thanks,

tglx