Re: [PATCH 1/2] cgroup: Add generation number with cgroup id

From: Namhyung Kim
Date: Sat Oct 26 2019 - 07:40:53 EST


On Fri, Oct 25, 2019 at 8:06 PM Tejun Heo <tj@xxxxxxxxxx> wrote:
> Sure, but I think we should get the userland visible behaviors right.
> Ignoring implementation details:
>
> * cgroup vs. css IDs doesn't matter for now. css IDs aren't visible
> to userland anyway and it could be that keeping using idr as-is or
> always using 64bit IDs is the better solution for them.

Yes, it can be done easily IMHO.

>
> * On 32bit ino setups, 32bit ino + gen as cgroup and export fs IDs.

This is the current behavior, right?

>
> * On 64bit ino setups, 64bit unique ino (allocated whichever way) + 0
> gen as cgroup and export fs IDs.

Hmm.. we still need gen for 64bit? Do you want 12-byte export fs ID?

Thanks
Namhyung