Re: [PATCH] tpm: Add major_version sysfs file

From: Jason Gunthorpe
Date: Sun Oct 27 2019 - 19:01:09 EST


On Sun, Oct 27, 2019 at 05:35:41PM +0200, Jarkko Sakkinen wrote:
> On Fri, Oct 25, 2019 at 07:28:47AM -0700, Jerry Snitselaar wrote:
> > Easily determining what TCG version a tpm device implements
> > has been a pain point for userspace for a long time, so
> > add a sysfs file to report the tcg version of a tpm device.
> >
> > Cc: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> > Cc: Peter Huewe <peterhuewe@xxxxxx>
> > Cc: Jason Gunthorpe <jgg@xxxxxxxx>
> > Cc: linux-integrity@xxxxxxxxxxxxxxx
> > Signed-off-by: Jerry Snitselaar <jsnitsel@xxxxxxxxxx>
>
> Please use version_major (e.g. if there is ever version_minor
> they order nicely alphabetically).

That is not the convention in sysfs

Jason