Re: [BUGFIX PATCH V2 0/6] perf/probe: Additional fixes for range only functions

[Masami Hiramatsu]

On Mon, 28 Oct 2019 11:16:55 -0300
Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> Em Sat, Oct 26, 2019 at 06:00:19PM +0900, Masami Hiramatsu escreveu:
> > Hi Arnaldo,
> > 
> > I've updated examples in patch description in this v2.
> > No changes in the code itself. I ran it on Ubuntu 19.04
> > (linux-5.0.0-32-generic).
> > 
> > Please replace previous one with this.
> 
> Can you please take a look at my perf/core branch? I have these already
> there:
> 
> 5e72f4349eff perf probe: Fix to show ranges of variables in functions without entry_pc
> 50fc0fda5f2c perf probe: Fix to show inlined function callsite without entry_pc
> d7bf48229b85 perf probe: Fix to list probe event with correct line number
> 39cee497850a perf probe: Fix to probe an inline function which has no entry pc
> 6150bad27ebd perf probe: Fix to probe a function which has no entry pc
> fdaea9eea92d perf probe: Fix wrong address verification
> 
> And I added committer notes doing the tests.

Yes, I confirmed your comments on the patches. It looks good to me.

Thank you!

> 
> - Arnaldo
>  
> > Thank you,
> > 
> > ---
> > 
> > Masami Hiramatsu (6):
> >       perf/probe: Fix wrong address verification
> >       perf/probe: Fix to probe a function which has no entry pc
> >       perf/probe: Fix to probe an inline function which has no entry pc
> >       perf/probe: Fix to list probe event with correct line number
> >       perf/probe: Fix to show inlined function callsite without entry_pc
> >       perf/probe: Fix to show ranges of variables in functions without entry_pc
> > 
> > 
> >  tools/perf/util/dwarf-aux.c    |    6 +++---
> >  tools/perf/util/probe-finder.c |   40 ++++++++++++++--------------------------
> >  2 files changed, 17 insertions(+), 29 deletions(-)
> > 
> > --
> > Masami Hiramatsu (Linaro) <mhiramat@xxxxxxxxxx>
> 
> -- 
> 
> - Arnaldo


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>