RE: [PATCH] dt-bindings: phy: renesas: usb2-phy: convert bindings to json-schema

From: Yoshihiro Shimoda
Date: Tue Oct 29 2019 - 00:14:24 EST


Hi Rob,

Thank you for your review!

> From: Rob Herring, Sent: Tuesday, October 29, 2019 10:57 AM
>
> On Fri, Oct 18, 2019 at 05:38:53PM +0900, Yoshihiro Shimoda wrote:
> > Convert Renesas R-Car generation 3 USB 2.0 PHY bindings documentation
> > to json-schema.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 70 --------------
> > .../devicetree/bindings/phy/renesas,usb2-phy.yaml | 106 +++++++++++++++++++++
> > 2 files changed, 106 insertions(+), 70 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> > create mode 100644 Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
>
>
> > diff --git a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > new file mode 100644
> > index 00000000..0f109c2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
> > @@ -0,0 +1,106 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/phy/renesas,usb2-phy.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Renesas R-Car generation 3 USB 2.0 PHY
> > +
> > +maintainers:
> > + - Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > +
> > +properties:
> > + compatible:
> > + oneOf:
>
> This:

What does the "This:" mean? If I replaced the "oneOf:" with "This:",
the following error happens when "make dt_binding_check":

SCHEMA Documentation/devicetree/bindings/processed-schema.yaml
warning: no schema found in file: Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml
[snip]/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml: ignoring, error in schema 'compatible'
Documentation/devicetree/bindings/Makefile:33: recipe for target 'Documentation/devicetree/bindings/processed-schema.yaml' failed
make[1]: *** [Documentation/devicetree/bindings/processed-schema.yaml] Error 255
Makefile:1263: recipe for target 'dt_binding_check' failed
make: *** [dt_binding_check] Error 2

> > + - items:
> > + - enum:
> > + - renesas,usb2-phy-r8a77470 # RZ/G1C
>
> You can simplify to just:
>
> - const: renesas,usb2-phy-r8a77470 # RZ/G1C

I'll fix it.

> > + - items:
> > + - enum:
> > + - renesas,usb2-phy-r7s9210 # RZ/A2
> > + - renesas,usb2-phy-r8a774a1 # RZ/G2M
> > + - renesas,usb2-phy-r8a774b1 # RZ/G2N
> > + - renesas,usb2-phy-r8a774c0 # RZ/G2E
> > + - renesas,usb2-phy-r8a7795 # R-Car H3
> > + - renesas,usb2-phy-r8a7796 # R-Car M3-W
> > + - renesas,usb2-phy-r8a77965 # R-Car M3-N
> > + - renesas,usb2-phy-r8a77990 # R-Car E3
> > + - renesas,usb2-phy-r8a77995 # R-Car D3
> > + - const: renesas,rcar-gen3-usb2-phy
> > +
> > + reg:
> > + # base address and length of the registers block for the PHY.
> > + maxItems: 1
> > +
> > + clocks:
> > + # clock phandle and specifier pair(s).
> > + minItems: 1
> > + maxItems: 2
> > +
> > + clock-names:
> > + # for RZ/A2
> > + minItems: 1
> > + maxItems: 2
> > + items:
> > + - const: fck
> > + - const: usb_x1
> > +
> > + '#phy-cells':
> > + # see phy-bindings.txt in the same directory
>
> Drop this so we don't have to fix later.

I'll drop this.

> > + enum: [0, 1] # and 0 is deprecated.
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + resets:
> > + minItems: 1
> > + maxItems: 2
>
> Needs 'items' to define each entry.

I'll add "items:" and two "description:" on the resets property.

> > +
> > + vbus-supply:
> > + $ref: /schemas/types.yaml#/definitions/phandle
>
> Can drop this, *-supply already has a type.

I'll drop it.

> > + description: |
> > + Phandle to a regulator that provides power to the VBUS. This regulator
> > + will be managed during the PHY power on/off sequence.
> > +
> > + renesas,no-otg-pins:
> > + $ref: /schemas/types.yaml#/definitions/flag
> > + description: |
> > + specify when a board does not provide proper otg pins.
> > +
> > + dr_mode:
> > + $ref: /schemas/types.yaml#/definitions/string
>
> I think we already have a common definition, so just 'true' is enough.

I'll fix it.

Best regards,
Yoshihiro Shimoda