Re: [PATCH] b43: Fix use true/false for bool type

From: Simon Horman
Date: Tue Oct 29 2019 - 04:43:51 EST


On Tue, Oct 29, 2019 at 01:30:34AM -0700, Joe Perches wrote:
> On Tue, 2019-10-29 at 09:24 +0100, Simon Horman wrote:
> > I wonder why bools rather than a bitmask was chosen
> > for this field, it seems rather space intensive in its current form.
>
> 4 bools is not intensive.

Thanks, point taken.

>
> > > diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
> []
> > > @@ -3600,7 +3600,7 @@ static void b43_tx_work(struct work_struct *work)
> []
> > > - wl->tx_queue_stopped[queue_num] = 1;
> > > + wl->tx_queue_stopped[queue_num] = true;
>
>