Re: [PATCH 0/5] net: ethernet: stmmac: some fixes and optimizations

From: David Miller
Date: Tue Oct 29 2019 - 21:09:09 EST


From: Christophe Roullier <christophe.roullier@xxxxxx>
Date: Tue, 29 Oct 2019 11:14:36 +0100

> Some improvements (manage syscfg as optional clock, update slew rate of
> ETH_MDIO pin, Enable gating of the MAC TX clock during TX low-power mode)
> Fix warning build message when W=1

Please fix up several issues with this submission:

1) Bug fixes should target the 'net' GIT tree. Anything else, and this
means cleanups, new features, and optimizations, should all target
the 'net-next' GIT tree.

2) Your subject lines are too much, for example:

[net: ethernet: stmmac: some fixes and optimizations 1/5] net: ethernet: stmmac: Add support for syscfg clock

The "net: ethernet: stmmac: some fixes and optimizations" part
should be completely removed. 'net' should be separate to indicate
the target GIT tree (or 'net-next' as could be the case) and then
we're left with, for example:

[PATCH net-next 1/5] net: ethernet: stmmac: Add support for syscfg clock

3) There should be a seprate series with the bug fixes targetting 'net',
then you should wait for those fixes to propagate into 'net-next', at which
time you can submit a second patch series targetting 'net-next' with all
the cleanups, feature additions, and optimizations.

Thank you.