Re: [PATCH v15 06/19] leds: lp50xx: Add the LP50XX family of the RGB LED driver

From: Jacek Anaszewski
Date: Wed Oct 30 2019 - 18:00:50 EST


Dan,

On 10/30/19 9:55 PM, Dan Murphy wrote:
> Jacek
>
> On 10/30/19 3:50 PM, Jacek Anaszewski wrote:
>> Dan,
>>
>> On 10/30/19 9:23 PM, Dan Murphy wrote:
>>> Jacek
>>>
>>>
>>>>> Does not appear here
>>>>>
>>>>> Finally not sure why the MIPS compiler is complaining about this
>>>>> but the
>>>>> ARM and x86 is not
>>>> Compilation breaks also for ARM.
>>> Thanks for the information.
>>>
>>> I am not seeing this issue or even a warning when using the ARM 8.3
>>> toolchain even in a clean build.
>>>
>>> arm-linux-gnueabihf-gcc (GNU Toolchain for the A-profile Architecture
>>> 8.3-2019.03 (arm-rel-8.36)) 8.3.0
>>>
>>> So is a bug in this toolchain?
>>  From what I've just googled C specification allows for a compiler
>> implementation to accept also other forms of constants expressions
>> than standard ones pointed out in the spec.
>>
>> So this is not necessarily a bug.
>>
> OK.  Well I will try to repo with the above instructions.  And wait till
> Friday for any other comments.  If I get no other comments I will make
> the couple of changes and then post v16.

I confirm that with arm-unknown-linux-gnueabi-gcc just built with
crosstool-NG 1.24.0 I don't observe the issue either.

Previously I used quite old gcc 5.2 or so.

--
Best regards,
Jacek Anaszewski