Re: [PATCH 2/2] input: adp5589: Add basic devicetree support

From: kbuild test robot
Date: Wed Oct 30 2019 - 23:07:31 EST


Hi Alexandru,

I love your patch! Perhaps something to improve:

[auto build test WARNING on input/next]
[also build test WARNING on next-20191030]
[cannot apply to v5.4-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Alexandru-Ardelean/input-adp5589-Add-default-platform-data/20191031-073612
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: x86_64-kexec (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

drivers/input/keyboard/adp5589-keys.c: In function 'adp5589_i2c_get_driver_data':
>> drivers/input/keyboard/adp5589-keys.c:1004:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
return (int)match->data;
^

vim +1004 drivers/input/keyboard/adp5589-keys.c

989
990 static int adp5589_i2c_get_driver_data(struct i2c_client *i2c,
991 const struct i2c_device_id *id)
992 {
993 const struct of_device_id *match;
994
995 if (id)
996 return id->driver_data;
997
998 if (!IS_ENABLED(CONFIG_OF) || !i2c->dev.of_node)
999 return -ENODEV;
1000
1001 match = of_match_node(i2c->dev.driver->of_match_table,
1002 i2c->dev.of_node);
1003 if (match)
> 1004 return (int)match->data;
1005
1006 return -ENODEV;
1007 }
1008

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip