Re: [PATCH 2/2] ARM: dts: at91: add a common kizboxmini dtsi file

[Alexandre Belloni]

On 29/10/2019 07:34:26-0500, Rob Herring wrote:
> On Fri, Oct 18, 2019 at 04:03:04PM +0200, Kamel Bouhara wrote:
> > Split the Kizbox Mini boards into two board configuration, the
> > Kizboxmini Mother board and the Kizboxmini RailDIN board.
> > 
> > Signed-off-by: Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx>
> > Signed-off-by: Kévin RAYMOND <k.raymond@xxxxxxxxxxx>
> > Signed-off-by: Mickael GARDET <m.gardet@xxxxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/Makefile                    |   2 +
> >  arch/arm/boot/dts/at91-kizboxmini-mb.dts      |  38 ++++
> >  arch/arm/boot/dts/at91-kizboxmini-rd.dts      |  54 ++++++
> >  arch/arm/boot/dts/at91-kizboxmini_common.dtsi | 166 ++++++++++++++++++
> >  4 files changed, 260 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/at91-kizboxmini-mb.dts
> >  create mode 100644 arch/arm/boot/dts/at91-kizboxmini-rd.dts
> >  create mode 100644 arch/arm/boot/dts/at91-kizboxmini_common.dtsi
> > 
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index c976b72a4c94..6b3a65f3f6f8 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -38,6 +38,8 @@ dtb-$(CONFIG_SOC_AT91SAM9) += \
> >  	at91-ariettag25.dtb \
> >  	at91-cosino_mega2560.dtb \
> >  	at91-kizboxmini.dtb \
> > +	at91-kizboxmini-mb.dtb \
> > +	at91-kizboxmini-rd.dtb \
> >  	at91-wb45n.dtb \
> >  	at91sam9g15ek.dtb \
> >  	at91sam9g25ek.dtb \
> > diff --git a/arch/arm/boot/dts/at91-kizboxmini-mb.dts b/arch/arm/boot/dts/at91-kizboxmini-mb.dts
> > new file mode 100644
> > index 000000000000..52921f547dd6
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/at91-kizboxmini-mb.dts
> > @@ -0,0 +1,38 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (C) 2015-2018 Overkiz SAS
> > + *   Author: Mickael Gardet <m.gardet@xxxxxxxxxxx>
> > + *           Kévin Raymond <k.raymond@xxxxxxxxxxx>
> > + */
> > +/dts-v1/;
> > +#include "at91-kizboxmini_common.dtsi"
> > +
> > +/ {
> > +	model = "Overkiz Kizbox Mini Mother Board";
> > +	compatible = "overkiz,kizboxmini-mb", "atmel,at91sam9g25",
> > +		     "atmel,at91sam9x5", "atmel,at91sam9";
> > +
> > +	clocks {
> > +		slow_xtal {
> 
> Don't use '_' in node names.
> 

We are stuck with that one until we change the dtsi.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com