Re: [PATCH 2/3] ARM: dts: sun8i: add FriendlyARM NanoPi Duo2

[Karl Palsson]

Chen-Yu Tsai <wens@xxxxxxxx> wrote:

(will fix all other comments)

> > +               // on opi-win, shutdown is pl4, is BT-RST-N is moduel pin 34
> > +               // YES; PG13 is correct.
> 
> I'm guessing all these comments are from your development
> cycle? Please remove them.

Yes, gross mistake squishing it all and rebasing, my apologies.

> 
> > +               shutdown-gpios = <&pio 6 13 GPIO_ACTIVE_HIGH>; /* PG13 */
> > +       };
> > +};
> 
> The board also has SPI flash. Can you add that as well?

It doesn't come mounted standard, it's just a blank footprint, so
I felt it should be left out?

Sincerely,
Karl Palsson

Attachment: OpenPGP-digital-signature.html
Description: OpenPGP Digital Signature