Re: [PATCH v2 12/13] um: add support for folded p4d page tables

[rppt]

<linux-c6x-dev@xxxxxxxxxxxxx>,linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>,linux-m68k <linux-m68k@xxxxxxxxxxxxxxxxxxxx>,linux-parisc <linux-parisc@xxxxxxxxxxxxxxx>,linux-um <linux-um@xxxxxxxxxxxxxxxxxxx>,sparclinux <sparclinux@xxxxxxxxxxxxxxx>,Mike Rapoport <rppt@xxxxxxxxxxxxx>
From: Mike Rapoport <rppt@xxxxxxxxxx>
Message-ID: <E5D8BD4D-5286-427C-A347-D73AC26EC256@xxxxxxxxxx>

On November 1, 2019 10:20:09 AM GMT+01:00, Richard Weinberger <richard@xxxxxx> wrote:
>----- UrsprÃngliche Mail -----
>> Von: "Mike Rapoport" <rppt@xxxxxxxxxx>
>
>[...]
>
>> #define pte_page(x) pfn_to_page(pte_pfn(x))
>> diff --git a/arch/um/kernel/mem.c b/arch/um/kernel/mem.c
>> index 417ff64..6fd17bc 100644
>> --- a/arch/um/kernel/mem.c
>> +++ b/arch/um/kernel/mem.c
>> @@ -92,10 +92,26 @@ static void __init one_md_table_init(pud_t *pud)
>> #endif
>> }
>> 
>> +static void __init one_pud_table_init(p4d_t *p4d)
>> +{
>> +#if CONFIG_PGTABLE_LEVELS > 3
>
>Isn't this dead code?
>
>For uml we have:
>config PGTABLE_LEVELS
>        int
>        default 3 if 3_LEVEL_PGTABLES
>        default 2

It's kinda a provision for 4 levels support in UML :)
I can drop this in the next respin, no problem.

>Thanks,
>//richard


-- 
Sincerely yours,
Mike