Re: [PATCH v2 0/9] Simplify MFD Core

[Lubomir Rintel]

On Fri, 2019-11-01 at 09:07 +0000, Lee Jones wrote:
> On Mon, 21 Oct 2019, Lubomir Rintel wrote:
> > On Mon, 2019-10-21 at 12:53 +0100, Lee Jones wrote:
> > > On Mon, 21 Oct 2019, Lubomir Rintel wrote:
> > > 
> > > > On Mon, 2019-10-21 at 13:29 +0200, Arnd Bergmann wrote:
> > > > > On Mon, Oct 21, 2019 at 12:58 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> > > > > > MFD currently has one over-complicated user.  CS5535 uses a mixture of
> > > > > > cell cloning, reference counting and subsystem-level call-backs to
> > > > > > achieve its goal of requesting an IO memory region only once across 3
> > > > > > consumers.  The same can be achieved by handling the region centrally
> > > > > > during the parent device's .probe() sequence.  Releasing can be handed
> > > > > > in a similar way during .remove().
> > > > > > 
> > > > > > While we're here, take the opportunity to provide some clean-ups and
> > > > > > error checking to issues noticed along the way.
> > > > > > 
> > > > > > This also paves the way for clean cell disabling via Device Tree being
> > > > > > discussed at [0]
> > > > > > 
> > > > > > [0] https://lkml.org/lkml/2019/10/18/612.
> > > > > 
> > > > > As the CS5535 is primarily used on the OLPC XO1, it would be
> > > > > good to have someone test the series on such a machine.
> > > > > 
> > > > > I've added a few people to Cc that may be able to help test it, or
> > > > > know someone who can.
> > > > > 
> > > > > For the actual patches, see
> > > > > https://lore.kernel.org/lkml/20191021105822.20271-1-lee.jones@xxxxxxxxxx/T/#t
> > > > 
> > > > Thanks for the pointer. I'd by happy to test this.
> > > > 
> > > > Which tree do the patches apply to?
> > > > Or, better, is there a tree with the patches applied that I could use?
> > > 
> > > Ideal.  Thank you.
> > > 
> > > http://git.linaro.org/people/lee.jones/linux.git/log/?h=topic/mfd-remove-clone-cs5535-mfd
> > 
> > Thanks. My boot attempt ends up in a panic [1]:
> 
> New patches have been drafted, reviewed and pushed to the same branch.
> 
> Would you be kind enough to boot test them for me please Lubo?

The branch

Tested-by: Lubomir Rintel <lkundrak@xxxxx> (OLPC XO-1)

Here's a dmesg and partial sysfs listing indicating that the driver
indeed bound correctly: https://paste.centos.org/view/3aa89258

> 
> TIA.

Take care
Lubo