Re: [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw

[Manivannan Sadhasivam]

On Fri, Nov 01, 2019 at 03:55:01PM +0000, Tudor.Ambarus@xxxxxxxxxxxxx wrote:
> 
> 
> On 11/01/2019 04:58 PM, Manivannan Sadhasivam wrote:
> >>> Add MTD support for w25q256jw SPI NOR chip from Winbond. This chip
> >>> supports dual/quad I/O mode with 512 blocks of memory organized in
> >>> 64KB sectors. In addition to this, there is also small 4KB sectors
> >>> available for flexibility. The device has been validated using Thor96
> >>> board.
> >>>
> >>> Cc: Marek Vasut <marek.vasut@xxxxxxxxx>
> >>> Cc: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
> >>> Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
> >>> Cc: Brian Norris <computersforpeace@xxxxxxxxx>
> >>> Cc: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> >>> Cc: Richard Weinberger <richard@xxxxxx>
> >>> Cc: Vignesh Raghavendra <vigneshr@xxxxxx>
> >>> Cc: linux-mtd@xxxxxxxxxxxxxxxxxxx
> >>> Signed-off-by: Darshak Patel <darshak.patel@xxxxxxxxxxxxxx>
> >>> [Mani: cleaned up for upstream]
> >> Can we keep Darshak's authorship? We usually change the author if we feel that
> >> we made a significant change to what was originally published.
> >>
> >> If it's just about cosmetics, cleaning or rebase, you can specify what you did
> >> after the author's S-o-b tag and then add your S-o-b, as you did above.
> >>
> > I'd suggest to keep Darshak's authorship since he did the actual change in
> > the bsp. I have to clean it up before submitting upstream and I mentioned
> > the same above.
> > 
> 
> Ok, I'll amend the author when applying, it will be Darshak.
> 

Ah no. I was saying we should keep both of ours authorship. It shouldn't
be an issue because we both are involved in the process.

Thanks,
Mani

> Thanks,
> ta