Re: [net v2 1/4] net: sgi: ioc3-eth: don't abuse dma_direct_* calls

From: Christoph Hellwig
Date: Sun Nov 03 2019 - 19:35:04 EST


On Sun, Nov 03, 2019 at 11:34:30AM +0100, Thomas Bogendoerfer wrote:
> From: Christoph Hellwig <hch@xxxxxx>
>
> dma_direct_ is a low-level API that must never be used by drivers
> directly. Switch to use the proper DMA API instead.
>
> Change in v2:
> - ensure that tx ring is 16kB aligned

FYI, I think this should be a separate patch. The lack of explicitly
alignment was just as broken before this patch as it is now.