Re: [PATCH 4/4] v4l2-ctl: Support setting V4L2_CTRL_TYPE_AREA controls

From: Ricardo Ribalda Delgado
Date: Mon Nov 04 2019 - 06:21:55 EST


Hi Hans

Sure I will fix this. Shall I resend it once you have updated the
headers on v4l-utils?

Best regards

On Mon, Nov 4, 2019 at 10:41 AM Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote:
>
> On 11/1/19 12:25 PM, Ricardo Ribalda Delgado wrote:
> > $ v4l2-ctl -d /dev/video1 -c area=123123x233
> >
> > Signed-off-by: Ricardo Ribalda Delgado <ribalda@xxxxxxxxxx>
> > ---
> > utils/v4l2-ctl/v4l2-ctl-common.cpp | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/utils/v4l2-ctl/v4l2-ctl-common.cpp b/utils/v4l2-ctl/v4l2-ctl-common.cpp
> > index 95339561..676b05e0 100644
> > --- a/utils/v4l2-ctl/v4l2-ctl-common.cpp
> > +++ b/utils/v4l2-ctl/v4l2-ctl-common.cpp
> > @@ -973,6 +973,10 @@ void common_set(cv4l_fd &_fd)
> > strncpy(ctrl.string, iter->second.c_str(), qc.maximum);
> > ctrl.string[qc.maximum] = 0;
> > break;
> > + case V4L2_CTRL_TYPE_AREA:
> > + sscanf(iter->second.c_str(), "%dx%d",
>
> Use %ux%u since these are unsigned values.
>
> Regards,
>
> Hans
>
> > + &ctrl.p_area->width, &ctrl.p_area->height);
> > + break;
> > default:
> > fprintf(stderr, "%s: unsupported payload type\n",
> > qc.name);
> >
>