Re: [PATCH] rtc: brcmstb-waketimer: add missed clk_disable_unprepare
From: Florian Fainelli
Date: Mon Nov 04 2019 - 12:36:24 EST
On 11/4/19 7:50 AM, Chuhong Yuan wrote:
> This driver forgets to disable and unprepare clock when remove.
> Add a call to clk_disable_unprepare to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@xxxxxxxxx>
This looks fine, you do not need to check for timer->clk, since the
clk_* APIs do that, and we made sure in the probe function that we would
not be passing a timer->clk handle which is valid.
Also feel free to add:
Fixes: c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer")
Thank you
--
Florian