Re: [PATCH v14 2/5] dma-buf: heaps: Add heap helpers

[John Stultz]

On Mon, Nov 4, 2019 at 11:34 AM John Stultz <john.stultz@xxxxxxxxxx> wrote:
>
> On Sun, Nov 3, 2019 at 8:13 AM <sspatil@xxxxxxxxxx> wrote:
> > On Fri, Nov 01, 2019 at 09:42:35PM +0000, John Stultz wrote:
> > > Add generic helper dmabuf ops for dma heaps, so we can reduce
> > > the amount of duplicative code for the exported dmabufs.
> > >
> > > This code is an evolution of the Android ION implementation, so
> > > thanks to its original authors and maintainters:
> > >   Rebecca Schultz Zavin, Colin Cross, Laura Abbott, and others!
> > >
> > > Cc: Laura Abbott <labbott@xxxxxxxxxx>
> > > Cc: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>
> > > Cc: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
> > > Cc: Liam Mark <lmark@xxxxxxxxxxxxxx>
> > > Cc: Pratik Patel <pratikp@xxxxxxxxxxxxxx>
> > > Cc: Brian Starkey <Brian.Starkey@xxxxxxx>
> > > Cc: Vincent Donnefort <Vincent.Donnefort@xxxxxxx>
> > > Cc: Sudipto Paul <Sudipto.Paul@xxxxxxx>
> > > Cc: Andrew F. Davis <afd@xxxxxx>
> > > Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> > > Cc: Chenbo Feng <fengc@xxxxxxxxxx>
> > > Cc: Alistair Strachan <astrachan@xxxxxxxxxx>
> > > Cc: Hridya Valsaraju <hridya@xxxxxxxxxx>
> > > Cc: Sandeep Patil <sspatil@xxxxxxxxxx>
> > > Cc: Hillf Danton <hdanton@xxxxxxxx>
> > > Cc: Dave Airlie <airlied@xxxxxxxxx>
> > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > > Reviewed-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>
> > > Reviewed-by: Brian Starkey <brian.starkey@xxxxxxx>
> > > Acked-by: Laura Abbott <labbott@xxxxxxxxxx>
> > > Tested-by: Ayan Kumar Halder <ayan.halder@xxxxxxx>
> > > Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
> >
> > I have one question and a naming suggestin below (sorry).
> >
> > Acked-by: Sandeep Patil <sspatil@xxxxxxxxxxx>
>
> > > +
> > > +static void dma_heap_buffer_vmap_put(struct heap_helper_buffer *buffer)
> > > +{
> > > +     if (!--buffer->vmap_cnt) {
> >
> > nit: just checking here cause I don't know the order in which vmap_get() and
> > vmap_put() is expected to be called from dmabuf, the manual refcounting
> > based map/unmap is ok?
> >
> > I know ion had this for a while and it worked fine over the years, but I
> > don't know if anybody saw any issues with it.

Sorry, I hit send before replying to this bit. I'll double check on this.

thanks again for the review!
-john