Re: spdxcheck.py complains about the second OR?

From: Joe Perches
Date: Mon Nov 04 2019 - 17:24:46 EST


On Mon, 2019-11-04 at 23:11 +0100, Thomas Gleixner wrote:
> On Fri, 1 Nov 2019, Masahiro Yamada wrote:
> > scripts/spdxcheck.py warns the following two files.
> >
> > $ ./scripts/spdxcheck.py
> > drivers/net/ethernet/pensando/ionic/ionic_if.h: 1:52 Syntax error: OR
> > drivers/net/ethernet/pensando/ionic/ionic_regs.h: 1:52 Syntax error: OR
> >
> > I do not understand what is wrong with them.
> >
> > I think "A OR B OR C" is sane.
>
> Yes it is, but obviously we did not expect files with 3 possible
> alternative licenses.

Perhaps just this, but the generic logic
obviously isn't complete.
---
scripts/spdxcheck.py | 1 +
1 file changed, 1 insertion(+)

diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py
index 6374e0..00be34 100755
--- a/scripts/spdxcheck.py
+++ b/scripts/spdxcheck.py
@@ -150,6 +150,7 @@ class id_parser(object):
| ID WITH EXC
| expr AND expr
| expr OR expr
+ | expr OR expr OR expr
| LPAR expr RPAR'''
pass