Re: [PATCH 4/4] mospost: remove unneeded local variable in contains_namespace()

[Matthias Maennich]

Hi!

On Tue, Oct 29, 2019 at 09:38:09PM +0900, Masahiro Yamada wrote:
> The local variable, ns_entry, is unneeded.
>
> While I was here, I also cleaned up the comparison with NULL or 0.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---

This was not directly sent to me, hence I missed it.
Nevertheless, please feel free to add

Reviewed-by: Matthias Maennich <maennich@xxxxxxxxxx>

Cheers,
Matthias
> scripts/mod/modpost.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index f7425f5d4ab0..f70b924f379f 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -239,10 +239,8 @@ static struct symbol *find_symbol(const char *name)
> static bool contains_namespace(struct namespace_list *list,
> 			       const char *namespace)
> {
> -	struct namespace_list *ns_entry;
> -
> -	for (ns_entry = list; ns_entry != NULL; ns_entry = ns_entry->next)
> -		if (strcmp(ns_entry->namespace, namespace) == 0)
> +	for (; list; list = list->next)
> +		if (!strcmp(list->namespace, namespace))
> 			return true;
>
> 	return false;
> --
> 2.17.1