Re: [RFC][PATCH] x86, mce, therm_throt: Optimize notifications of thermal throttle

From: Srinivas Pandruvada
Date: Tue Nov 05 2019 - 16:21:09 EST


On Tue, 2019-11-05 at 21:56 +0100, Borislav Petkov wrote:
> On Tue, Nov 05, 2019 at 12:36:32PM -0800, Srinivas Pandruvada wrote:
> > > That wants to be a bool judging by the context it is used in.
> >
> > I can change to bool, just didn't use it
> > https://yarchive.net/comp/linux/bool.html
>
> And are you using it in a union or where the size of bool - which is
> implementation-specific - plays any role, esp. in your particular use
> case?
No.

>
> > They are architectural MSRs and the fact that we are getting called
> > means that they are enabled by looking at CPUID bits.
>
> If the CPUID bits guarantees their presence, then the error handling
> is
> not absolutely necessary.
>
> Thx.
>