Re: [PATCH V2] ARM: dts: imx6q-logicpd: Enable ili2117a Touchscreen

[Adam Ford]

On Wed, Nov 6, 2019 at 10:18 AM Marco Felsch <m.felsch@xxxxxxxxxxxxxx> wrote:
>
> Hi Adam,
>
> On 19-11-06 08:23, Adam Ford wrote:
> > The LCD used with the imx6q-logicpd board has an integrated
> > ili2117a touch controller connected to i2c1.
> >
> > This patch adds the node to enable this feature.
> >
> > Signed-off-by: Adam Ford <aford173@xxxxxxxxx>
> > ---
> > ili2117 support is scheduled to be introduced for Kernel v5.5.
> >
> > V2:  Change node to touchscreen@26 and move comment about 5.5 to under the dashes
> >
> > diff --git a/arch/arm/boot/dts/imx6q-logicpd.dts b/arch/arm/boot/dts/imx6q-logicpd.dts
> > index d96ae54be338..7a3d1d3e54a9 100644
> > --- a/arch/arm/boot/dts/imx6q-logicpd.dts
> > +++ b/arch/arm/boot/dts/imx6q-logicpd.dts
> > @@ -73,6 +73,16 @@
> >       status = "okay";
> >  };
> >
> > +&i2c1 {
> > +     touchscreen@26 {
> > +             compatible = "ilitek,ili2117";
> > +             reg = <0x26>;
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&pinctrl_touchscreen>;
>
> This phandle already exists?

Yes it does exist, but it probably should not have been since there
was no user of it.  At least this fixes that.  :-)

adam

>
> Regards,
>   Marco
>
> > +             interrupts-extended = <&gpio1 6 IRQ_TYPE_EDGE_RISING>;
> > +     };
> > +};
> > +
> >  &ldb {
> >       status = "okay";
> >
> > --
> > 2.20.1
> >
> >
> >
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |