Re: [PATCH v1] tools/hv: async name resolution in kvp_daemon

[Olaf Hering]

Am Thu, 07 Nov 2019 14:39:11 +0100
schrieb Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>:

> Olaf Hering <olaf@xxxxxxxxx> writes:

> Is it only EAI_AGAIN or do you see any other return values which justify
> the retry? I'm afraid that in case of a e.g. non-existing hostname we'll
> be infinitely looping with EAI_FAIL.

I currently do not have a setup that reproduces the failure.
I think if this thread loops forever, so be it.

The report I have shows "getaddrinfo failed: 0xfffffffe Name or service not known" on the host side.
And that went away within the VM once "networking was fixed", whatever this means.
But hv_kvp_daemon would report the error string forever.

> > +	pthread_detach(t);  
> I think this should be complemented with pthread_cancel/pthread_join
> before exiting main().

If the thread is detached, it is exactly that: detached. Why do you think the main thread should wait for the detached thread?

Olaf

Attachment: pgpDh10zgS0hF.pgp
Description: Digitale Signatur von OpenPGP