Re: [PATCH 4.19 114/149] UAS: Revert commit 3ae62a42090f ("UAS: fix alignment of scatter/gather segments")

From: Greg Kroah-Hartman
Date: Fri Nov 08 2019 - 02:23:47 EST


On Thu, Nov 07, 2019 at 12:32:45PM +0100, Oliver Neukum wrote:
> Am Dienstag, den 05.11.2019, 17:38 +0100 schrieb Greg Kroah-Hartman:
> > > > Given this information, perhaps you will decide that the revert is
> > > > worthwhile.
> > >
> > > Damned if I do, damned if I do not.
> > > Check for usbip and special case it?
> >
> > We should be able to do that in the host controller driver for usbip,
> > right? What is the symptom if you use a UAS device with usbip and this
> > commit?
>
> Yes, that patch should then also be applied. Then it will work.
> Without it, commands will fail, as transfers will end prematurely.

Ok, I'm confused now. I just checked, and I really have no idea what
needs to be backported anymore. 3ae62a42090f ("UAS: fix alignment of
scatter/gather segments") was backported to all of the stable kernels,
and now we reverted it.

So what else needs to be done here?

thanks,

greg k-h