Re: [PATCH] media:usb:cpia2: Properly check framebuffer mmap offsets

From: Greg Kroah-Hartman
Date: Fri Nov 08 2019 - 15:49:58 EST


On Fri, Nov 08, 2019 at 09:50:36PM +0000, Omer Shalev wrote:
> The cpai2 driver's mmap implementation wasn't properly check for all
> possible offset values. Given a huge offset value , the calculation
> start_offset + size can wrap around to a low value and pass the check

I thought we checked that in the core of the kernel now, to keep all
drivers from not having to do this type of thing (as they obviously all
forgot to.) Why is this still needed here as well?

thanks,

greg k-h