Re: [PATCH v7 3/6] dt-bindings: clock: Convert qcom,mmcc to DT schema

From: Stephen Boyd
Date: Fri Nov 08 2019 - 17:41:08 EST


Quoting Jeffrey Hugo (2019-11-08 13:13:59)
> diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
> new file mode 100644
> index 000000000000..769b0869eb9d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bindings/clock/qcom,mmcc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Multimedia Clock & Reset Controller Binding
> +
> +maintainers:
> + - Stephen Boyd <sboyd@xxxxxxxxxx>

I'm maintainer? :) I guess it's fine, but probably should be someone at
qcom instead like Taniya?

> + - Jeffrey Hugo <jhugo@xxxxxxxxxxxxxx>
> +
> +description: |
> + Qualcomm multimedia clock control module which supports the clocks, resets and
> + power domains.
> +
> +properties:
> + compatible :
> + enum:
> + - qcom,mmcc-apq8064
> + - qcom,mmcc-apq8084
> + - qcom,mmcc-msm8660
> + - qcom,mmcc-msm8960
> + - qcom,mmcc-msm8974
> + - qcom,mmcc-msm8996
> +
> + '#clock-cells':
> + const: 1
> +
> + '#reset-cells':
> + const: 1
> +
> + '#power-domain-cells':
> + const: 1
> +
> + reg:
> + maxItems: 1
> +
> + protected-clocks:
> + description:
> + Protected clock specifier list as per common clock binding
> +
> +required:
> + - compatible
> + - reg
> + - '#clock-cells'
> + - '#reset-cells'
> + - '#power-domain-cells'
> +
> +examples:
> + # Example for GCC for MSM8960:

MMCC, not GCC right?

> + - |
> + clock-controller@4000000 {
> + compatible = "qcom,mmcc-msm8960";
> + reg = <0x4000000 0x1000>;
> + #clock-cells = <1>;
> + #reset-cells = <1>;
> + #power-domain-cells = <1>;
> + };
> +...
> --
> 2.17.1
>