Re: [PATCH v1 2/3] KVM: VMX: Do not change PID.NDST when loading a blocked vCPU

From: Paolo Bonzini
Date: Mon Nov 11 2019 - 09:50:50 EST


On 11/11/19 15:48, Joao Martins wrote:
>>>
>>> Fixes: c112b5f50232 ("KVM: x86: Recompute PID.ON when clearing PID.SN")
>>> Signed-off-by: Joao Martins <joao.m.martins@xxxxxxxxxx>
>>> Signed-off-by: Liran Alon <liran.alon@xxxxxxxxxx>
>> Something wrong in the SoB line?
>>
> I can't spot any mistake; at least it looks chained correctly for me. What's the
> issue you see with the Sob line?

Liran's line after yours is confusing. Did he help with the analysis or
anything like that?

Paolo

> The only thing I forgot was a:
>
> Tested-by: Nathan Ni <nathan.ni@xxxxxxxxxx>
>
>> Otherwise looks good.
> If you want I can resubmit the series with the Tb and Jag Rb, unless you think
> it's OK doing on commit? Otherwise I can resubmit.