Re: [PATCH v5 net-next 00/12] net: ethernet: ti: introduce new cpsw switchdev based driver

From: Grygorii Strashko
Date: Tue Nov 12 2019 - 04:49:26 EST




On 11/11/2019 19:08, Tony Lindgren wrote:
* Grygorii Strashko <grygorii.strashko@xxxxxx> [191109 15:16]:
Hi Tony,

On 24/10/2019 19:05, Tony Lindgren wrote:
Hi,

* Grygorii Strashko <grygorii.strashko@xxxxxx> [191024 10:10]:
This the RFC v5 which introduces new CPSW switchdev based driver which is
operating in dual-emac mode by default, thus working as 2 individual
network interfaces. The Switch mode can be enabled by configuring devlink driver
parameter "switch_mode" to 1/true:
devlink dev param set platform/48484000.ethernet_switch \
name switch_mode value 1 cmode runtime

Just wondering about the migration plan.. Is this a replacement
driver or used in addition to the old driver?


Sry, I've missed you mail.

As it's pretty big change the idea is to keep both drivers at least for sometime.
Step 1: add new driver and enable it on one platform. Do announcement.
Step 2: switch all one-port and dual mac drivers to the new driver
Step 3: switch all other platform to cpsw switchdev and deprecate old driver.

OK sounds good to me. So for the dts changes, we keep the old binding
and just add a new module there?

yes, in general.
As you can see Patch 11 I've rearranged cpsw nodes between boards so cpsw_new is enabled
only on one board. But, Am5/dr7 board are good candidates to enable cpsw_new in batch as
the have only dual_mac default cfg.


Or do you also have to disable some parts of the old dts?

it will be the case for am3/am5 most probably.

--
Best regards,
grygorii